components icon indicating copy to clipboard operation
components copied to clipboard

CI/CD proposal

Open medikoo opened this issue 4 years ago • 2 comments

@eahefnawy @ac360 I'd like to setup some CI/CD (with GitHub actions) In context of this repository.

I propose following:

  • Configure ESLint and Prettier with @serverless/eslint-config
  • Validate ESLint & Prettier formatting on master and every PR against master

We may also take into account following additional things:

  • Automatic publications of new versions to npm on version change in package.json
  • Git hooks that validate ESLint and Prettier formatting

Let me know

medikoo avatar Apr 22 '20 10:04 medikoo

Sounds good 👍 ... I'm still not sold on Git hooks though. Let's just put the basics in place first.

What are Google actions though?! Do you mean Github actions? 🤔

eahefnawy avatar Apr 24 '20 12:04 eahefnawy

Sounds good 👍 ... I'm still not sold on Git hooks though. Let's just put the basics in place first.

Yes, I proposed this more for discussion and not for initial setup.

What about though releases made through CD? Can we start with it upfront, or you prefer to eventually upgrade to that later?

What are Google actions though?! Do you mean Github actions?

🤦 ofc (updated description)

medikoo avatar Apr 24 '20 12:04 medikoo