components icon indicating copy to clipboard operation
components copied to clipboard

Scripts do not fail properly

Open mrowles opened this issue 4 years ago • 1 comments

Describe the bug A failed AWS command does not fail properly (meaning CI builds 'succeed' / fail silently

To Reproduce

  1. Push any change which will fail due to AWS constraints e.g., CloudFront exists for CNAME
  2. AWS Script will fail e.g., error: CNAMEAlreadyExists: One or more of the CNAMEs you provided are already associated with a different resource.
  3. Script fails silently

Expected behavior Script fails and with it, any CI build

Screenshots N/A

Desktop (please complete the following information): N/A

Additional context Adding the following should catch a failed script:

#!/usr/bin/env bash

shopt -s failglob
set -eu -o pipefail

serverless

mrowles avatar Mar 29 '20 20:03 mrowles

I can confirm this, having the same issue in Bitbucket pipelines.

Belco90 avatar Apr 17 '20 14:04 Belco90