serverless-aws-alias icon indicating copy to clipboard operation
serverless-aws-alias copied to clipboard

Fix: Export 'project-name-ServerlessAliasReference' does not exist.

Open Enase opened this issue 4 years ago • 25 comments

  • Fixes https://github.com/serverless-heaven/serverless-aws-alias/issues/181
  • adds support for serverless v2
  • drops support for serverless v1
  • updated dependencies

Enase avatar Mar 25 '20 20:03 Enase

@HyperBrain could you merge / release?

Enase avatar Mar 25 '20 20:03 Enase

What's the ETA for the fix to be merged?

lkolchin avatar Apr 09 '20 00:04 lkolchin

Sorry This bug is merged and release with new version? Currently I'm using serverless-aws-alias and it's effected and occurs error in deploy.

chauhm avatar Apr 24 '20 11:04 chauhm

can we get this released this week? This seems to be a fix much needed for people to use it with latest serverless versions

codezninja avatar May 26 '20 21:05 codezninja

@HyperBrain Can you kindly review the PR please? It'll be great to use this plugin with the latest framework core version.

Much appreciated!

joelmonyx avatar Jun 20 '20 22:06 joelmonyx

I get the error..

Serverless Error ---------------------------------------

Export 'project-name-ServerlessAliasReference' does not exist.

Get Support -------------------------------------------- Docs: docs.serverless.com Bugs: github.com/serverless/serverless/issues Issues: forum.serverless.com

Your Environment Information --------------------------- Operating System: win32 Node Version: 12.18.2 Framework Version: 1.74.1 Plugin Version: 3.6.15 SDK Version: 2.3.1 Components Version: 2.31.12

hyosangAhn avatar Jul 14 '20 09:07 hyosangAhn

How are people creating a new project with this plugin without this patch??? Every single time I create a new serverless project with it and I try to deploy I get this error

danielsan avatar Jul 21 '20 01:07 danielsan

I don't think anyone is creating new projects with the latest serverless version. Most likely they are locking down the serverless version

codezninja avatar Jul 21 '20 10:07 codezninja

Any news on this issue ? I'm also hitting this problem

sondreslathia avatar Aug 17 '20 14:08 sondreslathia

I am evaluating this plugin for a client and am in a situation where they can't use serverless <=1.62. Merging this fix would be very appreciated.

barnabef avatar Aug 18 '20 16:08 barnabef

Hey, does anyone can approve this merge ?

jefersonlemos avatar Aug 31 '20 14:08 jefersonlemos

Any chances of this PR to be approved?

siovaneDAZN avatar Sep 07 '20 08:09 siovaneDAZN

@HyperBrain, could you please review/merge this one? Since it's really a bottleneck for projects of mine, we don't want to give up on using this plugin)

harazdovskiy avatar Nov 04 '20 11:11 harazdovskiy

@HyperBrain Any updates?...

osevostianov avatar Dec 29 '20 12:12 osevostianov

@Enase Would you consider releasing it as a separate package (serverless-aws-alias-hotfixed)? It has been almost a year and most of us would really appreciate a working version. Thank you in advance.

Bielik20 avatar Jan 04 '21 07:01 Bielik20

@Bielik20 Feel free to use serverless-aws-alias-fixed

Hope it helps everyone..

Enase avatar Jan 09 '21 11:01 Enase

If this has been fixed, please merge. Would really appreciate it.

tanmay-kulkarni avatar Jan 12 '21 07:01 tanmay-kulkarni

@Bielik20 Feel free to use serverless-aws-alias-fixed

Hope it helps everyone..

I have issue with serverless-aws-alias-fixed

TypeError: Cannot read property 'Properties' of undefined

ABRIO-PR avatar Jan 18 '21 10:01 ABRIO-PR

@ABRIO-PR Hello! I didn't add or change any logic that somehow can affect 'Properties' property in this PR. Mb I can help with it, but a way you report the issue doesn't have something to do with software development.

Enase avatar Jan 18 '21 12:01 Enase

@Enase I set "role" at the provider and it working. But if set role at functions:

TypeError: Cannot read property 'Properties' of undefined at AwsAlias.module.exports (/home/and/work/serverless/node_modules/serverless-aws-alias-fixed/lib/stackops/lambdaRole.js:38:11) at AwsAlias.aliasHandleLambdaRole (/home/and/work/serverless/node_modules/serverless-aws-alias-fixed/lib/aliasRestructureStack.js:43:21) at AwsAlias.tryCatcher (/home/and/work/serverless/node_modules/bluebird/js/release/util.js:16:23) at Promise._settlePromiseFromHandler (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:544:35) at Promise._settlePromise (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:604:18) at Promise._settlePromise0 (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:649:10) at Promise._settlePromises (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:729:18) at Promise._fulfill (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:673:18) at PromiseArray._resolve (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:127:19) at PromiseArray._promiseFulfilled (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:145:14) at PromiseArray._iterate (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:115:31) at PromiseArray.init [as _init] (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:79:10) at Promise._settlePromise (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:601:21) at Promise._settlePromise0 (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:649:10) at Promise._settlePromises (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:729:18) at Promise._fulfill (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:673:18) at Promise._resolveCallback (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:489:14) at Promise._settlePromiseFromHandler (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:559:17) at Promise._settlePromise (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:604:18) at Promise._settlePromise0 (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:649:10) at Promise._settlePromises (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:729:18) at Promise._fulfill (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:673:18) at PromiseArray._resolve (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:127:19) at PromiseArray._promiseFulfilled (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:145:14) at PromiseArray._iterate (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:115:31) at PromiseArray.init [as _init] (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:79:10) at Promise._settlePromise (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:601:21) at Promise._settlePromise0 (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:649:10) at Promise._settlePromises (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:729:18) at Promise._fulfill (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:673:18) at Promise._resolveCallback (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:489:14) at Promise._settlePromiseFromHandler (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:559:17) at Promise._settlePromise (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:604:18) at Promise._settlePromise0 (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:649:10) at Promise._settlePromises (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:729:18) at Promise._fulfill (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:673:18) at PromiseArray._resolve (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:127:19) at PromiseArray._promiseFulfilled (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:145:14) at PromiseArray._iterate (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:115:31) at PromiseArray.init [as _init] (/home/and/work/serverless/node_modules/bluebird/js/release/promise_array.js:79:10) at Promise._settlePromise (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:601:21) at Promise._settlePromise0 (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:649:10) at Promise._settlePromises (/home/and/work/serverless/node_modules/bluebird/js/release/promise.js:729:18) at _drainQueueStep (/home/and/work/serverless/node_modules/bluebird/js/release/async.js:93:12) at _drainQueue (/home/and/work/serverless/node_modules/bluebird/js/release/async.js:86:9) at Async._drainQueues (/home/and/work/serverless/node_modules/bluebird/js/release/async.js:102:5) at Immediate.Async.drainQueues [as _onImmediate] (/home/and/work/serverless/node_modules/bluebird/js/release/async.js:15:14) at processImmediate (internal/timers.js:456:21) at process.topLevelDomainCallback (domain.js:137:15)

ABRIO-PR avatar Jan 18 '21 13:01 ABRIO-PR

@ABRIO-PR Could you provide serverless.yml sample? And pls make sure that it's not a duplicate of https://github.com/serverless-heaven/serverless-aws-alias/issues/178. Thanks in advance.

Enase avatar Jan 18 '21 14:01 Enase

@ABRIO-PR I'm not sure will it work or not, but you can try to apply this patch and let us know the result.

fix.patch

Index: lib/stackops/lambdaRole.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/lib/stackops/lambdaRole.js b/lib/stackops/lambdaRole.js
--- a/lib/stackops/lambdaRole.js	(revision eab5d8644d17d8b69ee7215bbbb2eb469bc39e57)
+++ b/lib/stackops/lambdaRole.js	(date 1610985200900)
@@ -34,13 +34,15 @@
 	const roleLogicalId = `IamRoleLambdaExecution${normalizedAlias}`;
 	const role = stageStack.Resources.IamRoleLambdaExecution;
 
-	// Set role name
-	if (role.Properties.RoleName['Fn::Join']) {
-		_.last(role.Properties.RoleName['Fn::Join']).push(this._alias);
-	}
+	if (role) {
+		// Set role name
+		if (role.Properties.RoleName['Fn::Join']) {
+			_.last(role.Properties.RoleName['Fn::Join']).push(this._alias);
+		}
 
-	stageStack.Resources[roleLogicalId] = stageStack.Resources.IamRoleLambdaExecution;
-	delete stageStack.Resources.IamRoleLambdaExecution;
+		stageStack.Resources[roleLogicalId] = stageStack.Resources.IamRoleLambdaExecution;
+		delete stageStack.Resources.IamRoleLambdaExecution;
+	}
 
 	// Replace references
 	const functions = _.filter(stageStack.Resources, ['Type', 'AWS::Lambda::Function']);

Enase avatar Jan 18 '21 15:01 Enase

Created a separate PR for this with only needed change https://github.com/serverless-heaven/serverless-aws-alias/pull/201

Abhijith-Nagaraja avatar Feb 05 '21 20:02 Abhijith-Nagaraja

@HyperBrain could this be merged? HyperBrain seems inactive in git over the last 2 years... Should we fork this plugin to a new repo?

dnascimento avatar Jun 12 '21 03:06 dnascimento

Can someone review and merge this please?

saschabraun avatar Oct 12 '21 13:10 saschabraun