TextFieldCounter icon indicating copy to clipboard operation
TextFieldCounter copied to clipboard

Block-Style Interaction?

Open geoffreywiseman opened this issue 7 years ago • 1 comments

Hey,

It's a matter of taste, but if I were going to use TextFieldCounter (I'm not, currently), I'd prefer a block for handling when max length is reached.

textField.onMaxLengthCrossed { overLimit in
  submitButton.isEnabled = !overLimit
}

I don't love onMaxLengthCrossed as a name, but I couldn't think of anything better right away, so if you decide to add a block handler, maybe you can think of a better name.

On that note, it seems important to have a notification on the delegate if the max limit is "unreached" as well -- for instance in the block above, to re-enable the submit button.

geoffreywiseman avatar May 08 '17 12:05 geoffreywiseman

Hello @geoffreywiseman

It's an interesting approach. Feel free to submit a PR with these changes.

serralvo avatar May 21 '17 01:05 serralvo