Philip Dubé comments

Results 156 comments of


                                            Philip Dubé

feat(delete,update,insert): Support build Insert with schema strings.

your autoformat obfuscates the rest of the PR

Improve inserter delivery guarantees

You would need to implement retries on error. Likely best to do so with reconnection. If you need exactly once semantics things will get more complicated

Postgres-to-Postgres bidirectional replication

We've looked at it (it's part of motivation for PG Type System), but it's not on roadmap

Postgres-to-Postgres bidirectional replication

This is no longer in scope for PeerDB

mysql: enum values are sometimes string, sometimes int

this is driven by `binlog_row_metadata = full` in cdc. in qrep we always receive the string info

Improving `Tuple` write performance (open for discussion)

1. I've recommended a general `interface Tuple { Get(int) any; Len() int }` 2. another option would be to support `Seq[any]` from iter All these will generally involve boxing each...

make storage api a feature

I've misunderstood these changes changed to storage feature, not sure if you want it as a default feature

MySQL: Need to figure out how to handle binlog retention for large table addition initial loads

Fix would also help postgres avoid slot lag: start reading sync batches right away

Sync flow: use metadata for last offset fetch and cancel groupCtx

seems like we should be running the sync loop as another `waitGroup.Go` so it can return syncErr to cancel the errgroup

ch: consolidate schema when destination table missing columns

this looks a bit wrong since it skips checking table mappings, but in this scenario I doubt table mappings are relevant