universum icon indicating copy to clipboard operation
universum copied to clipboard

[#245] Change length signature in Container

Open DK318 opened this issue 4 years ago • 1 comments

Description

Problem: length function in Container has Int return type, but it is more semantic to return Natural instead.

Solution: changed signature and length realizations (default and in instances).

Related issues(s)

Resolves #245

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

  • [x] I made sure my PR addresses a single concern, or multiple concerns which are inextricably linked. Otherwise I should open multiple PR's.
  • [x] If your PR fixes/relates to an open issue then the description should reference this issue. See also auto linking on github.

Related changes (conditional)

  • Tests

    • [x] If I added new functionality, I added tests covering it.
    • [x] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    I checked whether I should update the docs and did so if necessary:

    • [x] README
    • [x] Haddock
  • Record your changes

    • [x] I added an entry to the changelog if my changes are visible to the users and
    • [x] provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

  • [x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.

DK318 avatar Nov 03 '21 13:11 DK318

Please, can someone review this (@Martoon-00 @gromakovsky)

DK318 avatar Nov 15 '21 19:11 DK318