nix-npm-buildpackage icon indicating copy to clipboard operation
nix-npm-buildpackage copied to clipboard

Published 20 hours ago • verified publisher icon serokell

Handle file: dependencies

Open balsoft opened this issue 5 years ago • 5 comments

Ligo's website uses a file: dependency syntax in package.json. We need to handle that. It turned out to be pretty simple really.

balsoft avatar Apr 17 '20 23:04 balsoft

Why does the test fail?

zhenyavinogradov avatar May 01 '20 04:05 zhenyavinogradov

Because I'm using builtins.filterSource, and I probably shouldn't. I'll try to figure it out on Monday.

balsoft avatar May 15 '20 16:05 balsoft

@zhenyavinogradov please review again, tests work now

balsoft avatar May 19 '20 11:05 balsoft

Can you please also add a simple test case for this, so we can be sure that we don't break it in the future?

zhenyavinogradov avatar May 20 '20 13:05 zhenyavinogradov

Just ran into this issue; are we still planning on merging this feature?

angerman avatar Jun 17 '22 09:06 angerman