cockpit_GROUPS icon indicating copy to clipboard operation
cockpit_GROUPS copied to clipboard

suggestions for `vars` defaults

Open raffaelj opened this issue 6 years ago • 2 comments

assets.path doesn't exist anywhere in the cockpit code. Was it in a previous version or did you add it by mistake?

'finder.allowed_uploads' => 10, looks like a placeholder. The default could be a list with "save" file types, like: pdf, png, jpg, jpeg, svg, gif

raffaelj avatar Oct 20 '18 19:10 raffaelj

assets.path doesn't exist anywhere in the cockpit code. Was it in a previous version or did you add it by mistake?

I dont know where I got this from but there are still remains according to that within the cockpit code: https://github.com/agentejo/cockpit/search?q=assets.path&unscoped_q=assets.path


'finder.allowed_uploads' => 10, looks like a placeholder. The default could be a list with "save" file types, like: pdf, png, jpg, jpeg, svg, gif

I dont get what you mean by this. "finder.allowed_uploads" is nothing that was defined by me but rather a cockpit property I found in the code: https://github.com/agentejo/cockpit/search?q=finder.allowed_uploads&unscoped_q=finder.allowed_uploads

serjoscha87 avatar Oct 23 '18 16:10 serjoscha87

I dont know where I got this from but there are still remains according to that within the cockpit code:

I'm not 100% sure about this. I just did a search for "assets.path" in the cockpit dir and there was no result. There are some dynamic "asset.path", but they aren't related to any global setting. The constant ASSETS_URL is set in bootstrap.php and can be adjusted in config.yaml with edit: no, this is to adjust the assets dir for layout and .js files

paths:
    assets: custom/assets/path

I dont get what you mean by this.

allowed_uploads exists since 18th Aug to prevent uploading executible files through the finder and the assets manager: https://github.com/agentejo/cockpit/issues/839#issuecomment-414007156

raffaelj avatar Oct 23 '18 19:10 raffaelj