add TString deallocation step

Open dskkato opened this issue 4 years ago • 1 comments

When I compare TString usage in cppflow and tensorflow's unittest, it seems that deallocation step may be required. But I did not check actual implementation of TString, so if I am wrong, please let it go.

https://github.com/tensorflow/tensorflow/blob/2305f9d0a58921987788fbd1d8fa43eda888233f/tensorflow/core/platform/ctstring_test.cc#L34-L68

Jun 01 '21 04:06 dskkato

I believe this should be merged, though not tested. Thanks.

In addition, we also need to add test cases for the string typed tensor.

Sep 28 '21 12:09 ljn917

This solution does not work, as it deallocates before using the tensor.

Sep 23 '22 14:09 serizba