Hans Klunder

Results 113 comments of Hans Klunder

Given all the work that you already have done, is there anything we can do to land this PR?

@Ethan-Arrowood @jasnell @MattiasBuelens @mcollina It feels to me like we are almost there and you all put so much time in it that I think it would be sad to...

@mcollina @jasnell @Ethan-Arrowood @MattiasBuelens Fellow NodeJS enthousiasts, I appreciate that you are all very busy improving NodeJS! What can we do to land this PR and thereby land another improvement?...

Hi, thanks for asking! The challenge you have is that JSONschema behaves a bit differently than HTML when it comes to references. A `$ref` does not automatically include the file...

FYI: I just added a note referring to: [subSchemas.md](https://github.com/seriousme/fastify-openapi-glue/blob/master/docs/subSchemas.md) to README.md

If we treat URI's as URL's then we are opening a whole can of worms Some examples that should then also work: - `$ref: http://example.com/subschema.json` - `$ref: ftp://example.com/subschema.json` - etc...

FYI: I have added bundling functionality to https://github.com/seriousme/openapi-schema-validator See: https://github.com/seriousme/openapi-schema-validator?tab=readme-ov-file#cli-for-api-bundling and: https://github.com/seriousme/openapi-schema-validator?tab=readme-ov-file#instancevalidatebundlespecificationsubspecification- Hope this helps

@robertsLando the constructor of Aedes immediatly starts running,e.g. it contains: ```js this._heartbeatInterval = setInterval(heartbeat, opts.heartbeatInterval) ``` and: ```js that.publish({ topic: birthTopic, payload: bufId }, noop) ``` My suggestion would be...

btw: I'm still getting to know the codebase (and I got some days off, hence the extra activity, sorry for that 😉 ) so you might see some more optimization...