serilog-sinks-email icon indicating copy to clipboard operation
serilog-sinks-email copied to clipboard

Add extension as alternative for ICredentialsByHost

Open ArnaudB88 opened this issue 6 years ago • 5 comments

Add extension with port, username and password parameters so they can be used from the configuration:

This is a fix for #58

ArnaudB88 avatar Oct 24 '18 14:10 ArnaudB88

@merbla, @MaximRouiller is this sink still being maintained?

This fix is pretty useful in the lot of cases. Would be nice it this pull request will be accepted.

mishamyte avatar Jan 23 '19 09:01 mishamyte

I'll let @merbla handle those commits since he has merge rights to this project.

MaximRouiller avatar Jan 23 '19 14:01 MaximRouiller

@merbla @MaximRouiller +1 from me. This extension is useful to me as well as I am trying to keep all Serilog configuration in settings files.

donhuff avatar Jul 11 '19 17:07 donhuff

When might this appear in a new NuGet package? Not being able to configure the port in a config files is a big omission in today's world where ISP's are moving way from supporting port 25.

ptmahoney avatar Feb 24 '20 17:02 ptmahoney

Any hope of getting this merged soon?

jwillmer avatar Feb 11 '21 15:02 jwillmer

Port configuration went in with 3.0; sorry about the lack of response on this @ArnaudB88, this project was low on maintainer time for a long stretch and things got shifted around a bit during the catch-up phase. Thanks again for the PR!

nblumhardt avatar Jun 09 '24 21:06 nblumhardt