serilog-settings-configuration icon indicating copy to clipboard operation
serilog-settings-configuration copied to clipboard

Minimumlevel partial fix with IConfigurationRoot.Providers

Open HexHunter97 opened this issue 4 years ago • 2 comments

A partial fix for minimumlevel not being correctly overriden by higher priority providers.

The fix only works for the .NET 4.6.1+ and .NET Standard builds as the IConfigurationRoot interface did not have Providers in .NET 4.5.1.

I understand this is more of an annoyance than a real issue, but it's easy to miss.

HexHunter97 avatar Aug 28 '20 16:08 HexHunter97

Thanks! 👍 As it's a slightly tricky scenario, it would be great to have a test for this behavior, so we can lessen the risk of regression in the future.

nblumhardt avatar Aug 28 '20 21:08 nblumhardt

I realise the long lines are less than desirable, but I don't know how to break them up properly wihout without taking up too much vertical space. :( Any advice on the matter welcome.

HexHunter97 avatar Aug 29 '20 09:08 HexHunter97

Sorry about the long delay on this; merging to the 3.5.0-dev-* version now.

nblumhardt avatar Sep 13 '22 23:09 nblumhardt

It's ok, there are other priorities sometimes. Thanks for letting it in!

HexHunter97 avatar Sep 14 '22 05:09 HexHunter97