serilog-formatting-compact-reader icon indicating copy to clipboard operation
serilog-formatting-compact-reader copied to clipboard

Remove Newtonsoft.Json 9.0.0.0 signed assembly dependency

Open i2van opened this issue 6 years ago • 4 comments

Current package 1.0.3 requires only Newtonsoft.Json 9.0.0.0 signed assembly; otherwise binding redirect should be made, which sometimes is undesirable.

i2van avatar Jan 28 '19 14:01 i2van

Thanks for the note, @i2van. At the moment the implementation of this package makes this infeasible (it's highly-dependent on Newtonsoft.Json). I don't think this is a change we'll be able to make in the near future, but good to have the feedback, thanks!

nblumhardt avatar Jan 29 '19 03:01 nblumhardt

Can the Newtonsoft.Json version be updated with the latest version?

LiorBanai avatar Dec 14 '19 17:12 LiorBanai

Hi Lior, thanks for the note.

I think, currently, we'd introduce more breakage by moving the package dependency forwards, than by leaving things as-is and using a binding redirect. Is the dependency version causing issues in your app that aren't resolved by binding redirects (which the recent CSPROJ versions should add automatically)?

I am wondering whether, if we're going to make breaking changes to this package, we might not be better off building v2 on System.Text.Json ...?

Cheers, Nick

nblumhardt avatar Dec 16 '19 00:12 nblumhardt

Yeah, if by bumping up the version there are going to be breaking changes I agree that in this case it is even better to go directly to System.Text.Json (which has different defaults than Newtonsoft.)..

LiorBanai avatar Dec 16 '19 17:12 LiorBanai

Is the original issue here fixed now? (v3 seems to depend on Newtonsoft 13.0.3)

Numpsy avatar Jun 16 '24 09:06 Numpsy

Closing this one as stale; thanks :+1:

nblumhardt avatar Jun 16 '24 23:06 nblumhardt