serilog-aspnetcore icon indicating copy to clipboard operation
serilog-aspnetcore copied to clipboard

Update docs for ASP.Net 6

Open darcythomas opened this issue 3 years ago • 6 comments

darcythomas avatar Jan 05 '22 03:01 darcythomas

Thanks, Darcy! The WebHost.UseSerilog() call is not correct (should be Host.UseSerilog()) - I've written up an example https://blog.datalust.co/using-serilog-in-net-6/ and published a sample repo https://github.com/datalust/dotnet6-serilog-example - perhaps the README could draw on those?

Since .NET 6 is the current version, I think we should port/replace the current code samples in the README rather than add new sections (the older content will be obsolete soon, I guess).

Cheers! Nick

nblumhardt avatar Jan 05 '22 05:01 nblumhardt

Oops my bad re webhost vs host.

.net 5 vs 6 maybe I can create a separate .net 5 page and link to that.

Since it there will be some people who are still gonna need that.

On Wed, Jan 5, 2022, 18:47 Nicholas Blumhardt @.***> wrote:

Thanks, Darcy! The WebHost.UseSerilog() call is not correct (should be Host.UseSerilog()) - I've written up an example https://blog.datalust.co/using-serilog-in-net-6/ and published a sample repo https://github.com/datalust/dotnet6-serilog-example - perhaps the README could draw on those?

Since .NET 6 is the current version, I think we should port/replace the current code samples in the README rather than add new sections (the older content will be obsolete soon, I guess).

Cheers! Nick

— Reply to this email directly, view it on GitHub https://github.com/serilog/serilog-aspnetcore/pull/278#issuecomment-1005400528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQIWVXLVNSG6HLVZQRYTR3UUPLOHANCNFSM5LI5Q64Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

darcythomas avatar Jan 05 '22 06:01 darcythomas

Thanks for the follow-up @darcythomas; I don't think we need an additional .NET 5 page - we don't currently have pages for .NET 4, Core 1 - 3, etc.. There's already plenty of info on .NET 5 setup out there, plus, anyone targeting .NET 5 now will likely have already started their project, and so already configured this.

nblumhardt avatar Jan 05 '22 22:01 nblumhardt

It might be more valuable to have a how to setup in ASP.Net MVC. Those who can will probably move to .Net 6 quite easily, but those stuck on older MVC (my current problem for one project) could do with instruction on how to get Serilog working on that platform.

Shrug

I guess moving forward is ultimately the better direction, so I'll delete the old setup mark down file.

darcythomas avatar Jan 06 '22 21:01 darcythomas

@sungam3r Hey I think I have everything you noticed resolved. How do you feel about merging in to Dev?

darcythomas avatar Jan 16 '22 20:01 darcythomas

I have no write access. I'm just a reviewer.

sungam3r avatar Jan 17 '22 13:01 sungam3r

As someone new to Serilog, it's really confusing and unfortunate having to find blog posts on Google with information about how to set this up. Why put it in a blog post instead of just adding it to the repository? .NET 6 is now over a year old, and .NET 7 has been released.

glen-84 avatar Nov 25 '22 16:11 glen-84

Looks like we stalled a bit here unfortunately, so I've just run through and made some minimal/quick updates to line things up with the .NET 6+ style of program/host initialization:

https://github.com/serilog/serilog-aspnetcore

Hope this helps. Thanks for kicking this one off @darcythomas 👍

nblumhardt avatar Nov 28 '22 00:11 nblumhardt