serilog-sinks-notepad icon indicating copy to clipboard operation
serilog-sinks-notepad copied to clipboard

Add support for writing to new Notepad on Windows 11

Open bstordrup opened this issue 1 year ago • 4 comments

I have experienced that the current implementation of finding the notepadEditorHandle on Winodows 11 with the RichEditD2DTP class does not find the actual editor handle.

But by enumerating the child windows from the process MainWindowHandle, I do find it.

I'll make a pull request for this issue with my changes.

bstordrup avatar May 11 '23 13:05 bstordrup

Excellent. Thanks @bstordrup

augustoproiete avatar May 11 '23 17:05 augustoproiete

@augustoproiete, some complications. I do get a handle to a RichEditD2DTP window, but the text is never shown there. Digging further into it.

bstordrup avatar May 12 '23 05:05 bstordrup

OK. Found the issue. It seems like there has been a change in the structure of Notepad. I think it might be an internal structuring change in the application.

The version of Notepad that I have supports multiple documents in the same instance, so the RichEditD2DPT is not a direct child of the MainWindowHandle - it is located inside another window with ClassName "NotepatTextBox".

The structure is illustrated on the image.

  • Entry 0 is the main window with class name Notepad
  • Entry 4 is a window with class name NotepadTextBox. Parent window is Entry 0
  • Entry 5 is a window with class name RichEditD2PDT. Parent window is Entry 4.

I think earlier, RichEditD2PDT had the Main window a direct parent. So my change is that if I do not find a window handle by the direct FindWindowEx call with RichEditD2DPT, the child windows below MainWindowHandle is enumerated and the RichEditD2DPT handle is returned.

image

bstordrup avatar May 12 '23 11:05 bstordrup

A new issue now is that the Notepad application can have multiple documents open, and hence have multiple entries in the list with class name RichEditD2DPT. Then which one should be selected? It seems like the last one opened is the first one being found, so returning that one should be safe.

bstordrup avatar May 12 '23 11:05 bstordrup