serilog-sinks-grafana-loki icon indicating copy to clipboard operation
serilog-sinks-grafana-loki copied to clipboard

Message template is not updated while property renaming

Open mishamyte opened this issue 2 years ago • 4 comments

Which version of Serilog.Sinks.Grafana.Loki are you using?

v8.0.0-beta.0

Which version of .NET are you using?

net6.0

Describe the bug

New feature, that adds a level as a property fixes the collision with naming, but the MessageTemplate is not updated and rendered output is broken

To Reproduce

_logger.LogInformation("Hero's {level}", 42);

Expected behavior

Templated should be consistent with renamed properties names

Log/SelfLog output or exception with stacktrace

No response

Application or code sample, which could be used to reproduce a bug

No response

Additional context

image

I have read the documentation

mishamyte avatar Apr 01 '22 21:04 mishamyte

Many thanks for this fix, we are now using this lib again and it works perfectly! <3

rogeralsing avatar Jun 17 '22 12:06 rogeralsing

@rogeralsing seems like you are talking about another issue, aren't you?

mishamyte avatar Jun 17 '22 14:06 mishamyte

My bad. this one: #94

rogeralsing avatar Jun 17 '22 15:06 rogeralsing

After research I've found that it is not possible to fix it easily. So I think we will keep it for the future releases

mishamyte avatar Jul 13 '22 14:07 mishamyte