serilog-sinks-elasticsearch icon indicating copy to clipboard operation
serilog-sinks-elasticsearch copied to clipboard

Ability to specify rolling interval for the buffer files in DurableElasticsearchSink

Open andrey-kozlov-skuvault opened this issue 3 years ago • 1 comments
trafficstars

A few questions before you begin:

Is this an issue related to the Serilog core project or one of the sinks or community projects.
This issue list is intended for Serilog Elasticsearch Sink issues. If this issue relates to another sink or to the code project, please log on the related repository. Please use Gitter chat and Stack Overflow for discussions and questions.

Does this issue relate to a new feature or an existing bug?

  • [ ] Bug
  • [x] New Feature

What version of Serilog.Sinks.Elasticsearch is affected? Please list the related NuGet package. v. 8.4.1.

What is the target framework and operating system? See target frameworks & net standard matrix.

  • [ ] netCore 2.0
  • [ ] netCore 1.0
  • [ ] 4.7
  • [ ] 4.6.x
  • [ ] 4.5.x
  • [ ] 4.8
  • [x] netstandard2.0

Please describe the current behavior? Now we cannot specify rolling interval for the buffer files in DurableElasticsearchSink. RollingInterval.Day is used always. We need more flexibility here to e.g. managing file granularity in a ways different from setting limit by buffer file size and count. We do not want to use these limits to ensure that not synced files won't be deleted in any case before they will be synced to the Elasticsearch. Using this limits we have such possibility (there are some cases when not synced file could be removed), so setting these are not an option for us.

Please describe the expected behavior? There is a possibility to specify RollingInterval for DurableElasticsearchSink

If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem

andrey-kozlov-skuvault avatar Mar 24 '22 18:03 andrey-kozlov-skuvault

Done in https://github.com/serilog-contrib/serilog-sinks-elasticsearch/pull/416

andrey-kozlov-skuvault avatar Apr 05 '22 14:04 andrey-kozlov-skuvault