serilog-sinks-elasticsearch icon indicating copy to clipboard operation
serilog-sinks-elasticsearch copied to clipboard

Published 20 hours ago • verified publisher icon serilog-contrib

Fixed errors not logging to SelfLog

Open TooLazyToMakeAName opened this issue 4 years ago • 6 comments

What issue does this PR address? Elasticsearch error messages not logged to selflog. #280

Does this PR introduce a breaking change? No.

Please check if the PR fulfills these requirements

  • [x] The commit follows our guidelines
  • [ ] Unit Tests for the changes have been added (for bug fixes / features)

TooLazyToMakeAName avatar Oct 16 '19 12:10 TooLazyToMakeAName

@TooLazyToMakeAName can't wait to have this corrected and merged - thank you.

ffMathy avatar Oct 24 '19 18:10 ffMathy

I too am affected by this issue and would love to see this fix get through. @mivano if @TooLazyToMakeAName is MIA for much longer I am willing to take this over and push it across the finish line.

kierseFG avatar Mar 13 '20 22:03 kierseFG

Please do, I m not using the sink itself, so anybody that can provide some help to indicate that this is a needed change is more than welcome.

mivano avatar Mar 15 '20 19:03 mivano

Any progress?

ffMathy avatar Jun 26 '20 14:06 ffMathy

Sorry, nothing from me. Not actively using the sink at the moment. If someone can pick this up and validate that this is working as desired, we can merge it in.

mivano avatar Jul 07 '20 21:07 mivano

I think with another PR, this might not be needed anymore?

mivano avatar Sep 16 '20 21:09 mivano

Too much drift, other changes got in as well. So closing this one.

mivano avatar Jan 29 '23 00:01 mivano