website icon indicating copy to clipboard operation
website copied to clipboard

Add friendlyName to PortInfo interface <superseeded - will delete upon confirmation of alternative fix>

Open GazHank opened this issue 2 years ago • 2 comments
trafficstars

Update documentation per fix for https://github.com/serialport/node-serialport/issues/2600

Adds friendlyName (Windows specific property) to Port definition

GazHank avatar Jun 20 '23 08:06 GazHank

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 8:37am

vercel[bot] avatar Jun 20 '23 08:06 vercel[bot]

I've proposed an alternative set of changes to cover this and allow for the fact that lowLatency is returned as False when getting port info on Mac and Win. This resulted in changes to bindings-interface, bindings-cpp, bindings-mock, and the website... I don't think it requires any changes to the node-serialport repository since we have allowed undefined. Please let me know if I've missed anything, or if you would like to suggest any additional changes

ps - while I added lowLatency to the Get PortInfo for all platforms, I've left the Set Port Options as it was (linux specific)

GazHank avatar Jun 20 '23 17:06 GazHank