bindings-cpp icon indicating copy to clipboard operation
bindings-cpp copied to clipboard

Published 20 hours ago • verified publisher icon serialport

Fix unsupported architecture for MacOS

Open GlaceCoding opened this issue 2 years ago • 4 comments

Hi,

With OTHER_ prefix my macos is not able to build the module with node-gyp. With this fix it is able to build. :)

fix: #99

GlaceCoding avatar Jan 14 '23 23:01 GlaceCoding

Thanks for this, @GlaceCoding! It would be nice to get this merged.

papakpmartin avatar Mar 03 '23 16:03 papakpmartin

@reconbot ☝🏻

(I don't know if you watch this repository, I allow myself to ping you.)

GlaceCoding avatar Mar 04 '23 09:03 GlaceCoding

I was asking my self it is really 'OTHER_CFLAGS' that you want to do ?

It looks like you're on an older os and xcode? none of my machines or CI have issues with the "other" flags. We've had it setup this way for over 10 years. However, it seems to build fine with this change, it needs some testing. I'd feel more comfortable if I knew the impact of the change but I can't find documentation. It is the way it is because it got that way.

reconbot avatar Apr 20 '23 16:04 reconbot

I tried on a Mojave but I thought my teammate had last macbook air version (because they need to do it also) 🤔

GlaceCoding avatar Apr 21 '23 19:04 GlaceCoding

This doesn't seem to be an issue for most OSs

reconbot avatar Oct 18 '24 20:10 reconbot