Sergio Padrino
Sergio Padrino
@jesseframework out of curiosity, are you trying it out with a big changeset? Those seem to be problematic (they weren't while we were developing the feature, so we're trying to...
Hopefully this should be fixed by now. Since it's already available in beta, I'm gonna close this 😄
I think a feature request is correct, thank you for your report 💖 I just checked and when Desktop retrieves the list of Pull Requests (each of them includes a...
@rhetoric101 Usually, repositories can be accessed via HTTPS and SSH (unless some restriction is set like in your GitHub Enterprise). Regardless of how the fork was cloned/pushed, GitHub Desktop retrieves...
Hey @opoplawski 👋 Thank you for your report. I'm not very well-versed on Desktop's HTTPS proxy support. Could you explain to me what's the problem exactly? You need Desktop to...
@opoplawski I'm surprised it hits `https://PROXY_HOST/api/v3/meta` since `https_proxy` is only used for git related stuff. The `/api/v3/meta` endpoint is used only to when trying to sign in, to see if...
Interesting. Thanks for the hint on `isGitHubHost`, I forgot we also hit `/meta` there 🤦♂ Other than that, if you don't see the issue on beta, I think the only...
For more info, it makes sense that the `https_proxy` stuff is getting to that point because as you say the URL is coming from git. Git requests the credentials for...
@opoplawski I've prepared a test build based on the changes you can see in https://github.com/desktop/desktop/pull/19071 If you wanna give it a try, that'd be super helpful! Here you have the...
@opoplawski hello 👋 Did you have a chance to try that test build out? It'd be super helpful to get feedback about those changes, thank you! 🙏