Sergio Padrino

Results 331 comments of Sergio Padrino

😱😱😱 In theory that should only happen for every PR where you're the author, and only when the CI jobs run and fail. I wouldn't expect anything like what you...

It should only send 1 notification per check suite 😱 And from what I see, your PR should only have 1 check suite with many many check runs. Is it...

Thanks for the info! If you've seen this recently (we haven made changes in notifications on the GitHub Desktop side for a long time), maybe the behavior changed on the...

Nope, I didn't get a notification at all 😞 Which might be a different bug/issue. However I tried with this other one #15451 and managed to get multiple notifications for...

I made a few changes (and fixes) on the backend side and at least I didn't get many notifications. @ofek could you give it a try and let me know?...

I can't repro this on macOS Monterey. Does it happen only when the cursor comes from Desktop?

I'm 99.99% sure this is due to the Electron upgrade in 3.0.8 😕

I've been looking into this, and I _think_ the problem lies in the electron function that we use (`openExternal`): https://github.com/electron/electron/blob/dcd216984fb7e823758a2fac1378b8d5a0f1774b/shell/common/platform_util_win.cc#L236-L254 Or, technically, it could even be [Chromium's GURL::spec method](https://chromium.googlesource.com/chromium/src/+/master/url/gurl.h#112) who...

@tidy-dev the idea was not bothering users with notifications from repositories other than the currently selected one. The notification dialog, however, has a "Switch to repository" button because you might...