Sergii Tkachenko comments

Results 84 comments of


                                            Sergii Tkachenko

[Fix][Python] Add validation for incomplete SSL key-cert pairs

@gtcooke94 Please take a look if this makes sense to you.

[python] aio: race condition causes `asyncio.run()` to hang forever during the shutdown process

@kevin85421 added this to gRPC Python triage meeting agenda.

[python] aio: race condition causes `asyncio.run()` to hang forever during the shutdown process

@kevin85421 I didn't get around reviewing the PR yet. I'll deflake the CI.

[python] aio: race condition causes `asyncio.run()` to hang forever during the shutdown process

@kevin85421 Please don't do that. Tagging unrelated contributors won't make it merge faster. We have limited resources and a process for reviewing code contribution. Your PR needs 2 approvals from...

[python] aio: race condition causes `asyncio.run()` to hang forever during the shutdown process

It's alright. Nobody is here to fight. Just saying tagging unrelated people is not productive. That said, I can't seem to reproduce the deadlock. Here's what I tried: https://github.com/sergiitk/grpc-py-repro/tree/main/40989-aio-deadlock From...

[python] aio: race condition causes `asyncio.run()` to hang forever during the shutdown process

Just reproduced it after several re-runs. Though it's inconsistent on my side. ``` $ ss -xpnm state connected | grep 139574 u_str ESTAB 0 0 * 516168 * 516167 users:(("python3",pid=139574,fd=5))...

[python] aio: race condition causes `asyncio.run()` to hang forever during the shutdown process

@kevin85421 Good news. Internal tests passed, the repo is being unlocked now. I'm hoping to get this merged today. > The issue can be consistently reproduced in some more stressful...

[python] aio: race condition causes `asyncio.run()` to hang forever during the shutdown process

This is merged now.

[python] Client SSL Certificate Hot-Reloading

@gtcooke94 please take a look

[Python] gRPC channel creation/close causes memory leak with concurrent file I/O

Thanks for the detailed report! To clarify, you tested all previous versions and found that only 1.75.1 is affected, or all of them down to 1.48.2? And did you try...