react-native-easy-router icon indicating copy to clipboard operation
react-native-easy-router copied to clipboard

Incorporate React Native Screens

Open christianchown opened this issue 5 years ago • 8 comments

It looks like this is a library to hook into the native navigation containers - could be a performance booster?

There's a guide here... https://github.com/kmagiera/react-native-screens#guide-for-navigation-library-authors

christianchown avatar Mar 11 '19 21:03 christianchown

But it's native. Then you won't be able to use it with Expo.

пн, 11 мар. 2019 г. в 23:39, Christian Chown [email protected]:

It looks like this is a library to hook into the native navigation containers - could be a performance booster?

There's a guide here... https://github.com/kmagiera/react-native-screens#guide-for-navigation-library-authors

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sergeyshpadyrev/react-native-easy-router/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ29YlHqDYqoX83JO3QmP7wkK2y9ysSsks5vVs0PgaJpZM4bpnge .

sergeyshpadyrev avatar Mar 12 '19 08:03 sergeyshpadyrev

Actually, it is https://github.com/kmagiera/react-native-screens#usage-in-expo-with-react-navigation

scottmas avatar Mar 12 '19 17:03 scottmas

@sergeyshpadyrev can you please reconsider it? expo does support React Native Screens, it would be a performance booster...

sijad avatar Aug 06 '19 15:08 sijad

Do you have some perfomance problems? Have you seen v3?

вт, 6 авг. 2019 г., 18:39 Sajjad Hashemian [email protected]:

@sergeyshpadyrev https://github.com/sergeyshpadyrev can you please reconsider it? expo does support React Native Screens, it would be a performance booster...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sergeyshpadyrev/react-native-easy-router/issues/31?email_source=notifications&email_token=ACO32YV6MIBXWLFFYEESSNDQDGLM3A5CNFSM4G5GPAPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VR5VA#issuecomment-518725332, or mute the thread https://github.com/notifications/unsubscribe-auth/ACO32YVG7DU3PNKPFMAPLKLQDGLM3ANCNFSM4G5GPAPA .

sergeyshpadyrev avatar Aug 06 '19 15:08 sergeyshpadyrev

No I didn't upgraded to v3 yet. if you decide to add react-native-screens to this project I guess it can be optional, specially with React Native 0.60+ which you don't even need to link packages...

sijad avatar Aug 06 '19 16:08 sijad

I must admit v3 seems faster, but I still think react-native-screens can improve performance specially with a deep stack.

sijad avatar Aug 07 '19 04:08 sijad

I got a new request for this feature so I decided to try to do it.

sergeyshpadyrev avatar Mar 07 '20 16:03 sergeyshpadyrev

I've tried to implement this but faced this bug: https://github.com/software-mansion/react-native-screens/issues/61

sijad avatar Mar 08 '20 19:03 sijad