python-zstd icon indicating copy to clipboard operation
python-zstd copied to clipboard

Latest release (1.5.7-r0) had wheel-building action failed, causing build on installation causing failures if build is not available

Open DaniilAnichin opened this issue 8 months ago • 6 comments

When attempting to install libraries that rely on zstd without a specific version specified, it always pulls the last, and with 1.5.7.0 version installation tries to build the wheel inside docker because, I assume, the github action for the wheels failed on May 5th or so. Build inside docker required gcc which can be missing as it is not otherwise required for the library. Is is possible to restart actions & get proper wheels for the latest version? Thanks in advance

DaniilAnichin avatar May 08 '25 15:05 DaniilAnichin

I know that wheels for python3.12 amd64 is missing, but I don't know how to fix it. I tried restarting action already.

sergey-dryabzhinsky avatar May 09 '25 06:05 sergey-dryabzhinsky

One of the potential reasons for the test failure on 3.12 is this:

  1. setuptools 72.0.0 removed the support for setup.py test command
  2. python3.12 tests install setuptools 80.3.1, while 3.11 installs 71.1.0
  3. probably pinning setuptools at <72.0.0 will change the behaviour, but not 100%

But also the thing is, for me the failing install happens not for 3.12, but for 3.11 instead; 1.5.6.7 worked fine, 1.5.6.8 and 1.5.7.0 try to build

DaniilAnichin avatar May 09 '25 08:05 DaniilAnichin

Yes, I installed setuptools<72 for 3.12. And tests running fine locally, but in action module loading failed.

sergey-dryabzhinsky avatar May 25 '25 14:05 sergey-dryabzhinsky

Have you tried latest 1.5.7.2 version?

sergey-dryabzhinsky avatar Jul 14 '25 09:07 sergey-dryabzhinsky

Seems like 1.5.7.2 works as expected, thanks; What was the required change? I've noticed some changed regarding build that github places in 1.5.7.1 release, but that one doesn't have wheels (same as 1.5.6.8 and 1.5.7.0)

Edit: retested with 1.5.7.1, and it does seem to work, so I assume build configuration is the thing that resolved it; But will wait for the response anyway

DaniilAnichin avatar Jul 14 '25 13:07 DaniilAnichin

Maybe I changed something in github actions, I don't remember clearly.

sergey-dryabzhinsky avatar Jul 15 '25 12:07 sergey-dryabzhinsky