recorder manual ignored

[janiel14]

I am programmer analyst and I have been using nginx-rtmp for some time and recently implementing recording feature I encountered a problem when using the configuration below:

application myapp { live on;

 recorder rec1 {
       record all manual;
 }

}

Above is just an example, the question is that the manual flag is no longer being respected, in other words, if there is a RECORDER setting it will always record. I am modifying the ngx_rtmp_record_module.c file in an attempt to fix the problem but I have little experience with c. The part which I imagine the problem is this:

for (n = 0; n < ctx->rec.nelts; ++n, ++rctx) {
    if (rctx->conf->flags & (NGX_RTMP_RECORD_OFF|NGX_RTMP_RECORD_MANUAL)) {
        continue;
    }
    ngx_rtmp_record_node_open(s, rctx);
}

line 681

I thank you for your attention

[chriswiggins]

@janiel14 where did you get that configuration from? I believe looking at the directives and the source code you're using the wrong config. Directives are here

It should look like this

application myapp {
   live on;
   record all manual;
}

In saying that, I think the recording functionality is broken at the moment anyway, but give that a go

[Fenrirthviti]

This is already an open issue, see #214

[olablt]

any updates? how to fix this?