milton icon indicating copy to clipboard operation
milton copied to clipboard

Problem with future combatibility in serializing bindings

Open aameen951 opened this issue 6 years ago • 0 comments

I found something that will cause a problem in the future when adding new key bindings:

https://github.com/serge-rgb/milton/blob/c2a9dc3d9e6c045d1d71cbcdb08b0e56cb2b9ee7/src/bindings.h#L50-L57

Adding new bindings must be before Action_COUNT. However, this reordering will cause a compatibility issue when reading the setting from file since it will be loaded into the wrong index.

aameen951 avatar Oct 27 '19 18:10 aameen951