Added import test to fix import for parse_rc

[icnocop]

Fixes #92

[codecov-io]

Codecov Report

Merging #97 into master will increase coverage by 1.04%. The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   52.05%   53.09%   +1.04%     
==========================================
  Files          91       91              
  Lines        6901     6904       +3     
  Branches     1730     1731       +1     
==========================================
+ Hits         3592     3666      +74     
+ Misses       2645     2561      -84     
- Partials      664      677      +13

Impacted Files	Coverage Δ
lib/Serge/Importer.pm	42.85% <100%> (+40.37%)	:arrow_up:
lib/Serge/Engine/Plugin/parse_rc.pm	78.33% <50%> (+2.89%)	:arrow_up:
lib/Serge/Engine.pm	60.73% <0%> (ø)	:arrow_up:
lib/Serge/Engine/Job.pm	87.87% <0%> (+1.01%)	:arrow_up:
lib/Serge/Plugin/Base.pm	86.36% <0%> (+4.54%)	:arrow_up:
lib/Serge/Interface/PluginHost.pm	94.44% <0%> (+16.66%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa5ac6b...eb7a379. Read the comment docs.

[icnocop]

I've updated the PR with your code comments and added https://github.com/evernote/serge/pull/98 for the typo and refactoring as suggested.

Thank you.

[icnocop]

When I took out passing $hint as the last parameter to $callbackref, the test fails with the error:

Parser plugin didn't provide a key value in a callback. Importing translations with this plugin is not possible, unless you use `--disambiguate-keys` option.

Is that expected given the input file application.rc?

If so, can you explain why, please?

All the keys in the STRINGTABLE are unique, so I don't expect any disambiguity.

When I pass $idstr as the last parameter to $callbackref, the test fails with errors like:

Duplicate key 'BEGIN' found in source file