serge icon indicating copy to clipboard operation
serge copied to clipboard

Prebuilt compose file, Buildx caching, readme updates

Open ReSyncc opened this issue 2 years ago • 4 comments

Added a compose file that uses the GitHub container registry to get the latest build including some readme documentation, @manudiv16 added builds support for caching.

ReSyncc avatar Mar 26 '23 02:03 ReSyncc

Hey @robotdjman ! Thanks for making this. I was thinking about this since we also now have an example of integration with kubernetes in #71.

I'd like to move the integration examples with docker compose and kubernetes to the wiki, so the code repo can be focused on the serge image itself.

I think they're quite good examples but since they don't contribute directly to building the image, I think they belong more in the wiki. What do you think ?

nsarrazin avatar Mar 26 '23 10:03 nsarrazin

@nsarrazin Oh yeah if we are getting a wiki setup that is definitely the way to go. The build caching would be something to pull into release (dropped builds from 2.5 minutes to 30 seconds). I don't believe there is a way to just pull everything but the readme commit c7521d6 right?

Edit: You can view the speed increase on my fork here https://github.com/robotdjman/serge/actions.

ReSyncc avatar Mar 26 '23 17:03 ReSyncc

@robotdjman Can you fix the merge conflicts? Awesome work!

gaby avatar Mar 26 '23 17:03 gaby

Fixed the merge and removed the added documentation of using the prebuilt docker compose file since it will be added to the wiki later.

ReSyncc avatar Mar 26 '23 17:03 ReSyncc

@nsarrazin This one should be good to merge

gaby avatar Mar 26 '23 18:03 gaby

@robotdjman I'd say to make those last changes in a separate PR to get this one merged.

gaby avatar Mar 26 '23 18:03 gaby

Seems like this branch is a bit out of date now. The workflow and the images both have been updated... I'm closing it for now, unless I missed something.

nsarrazin avatar Mar 27 '23 15:03 nsarrazin