Sergio Garcia comments

Results 52 comments of


                                            Sergio Garcia

fix(loader): Fix runs with no check exclusions

Hi @hb3b, thank you for reaching out! I am running Prowler with groups and it works for me. Could you send us snapshots of the unexpected behavior?

fix(loader): Fix runs with no check exclusions

Hi @hb3b, please reopen this PR if you are still with this problem.

delete(extra7145): It is redundant to check_extra798

Hi @kagahd, good catch, thank you for your contribution! But, why did you remove the cron from the [refresh_aws_services_regions.yml](https://github.com/prowler-cloud/prowler/pull/1420/commits/e15d07c8bf6cea3a50521f42d7826146ffe75386)?

delete(extra7145): It is redundant to check_extra798

Hi @kagahd, sorry for the delayed response. The check is duplicated and we included it in the roadmap of the new version 3 that we will release soon. Stay tuned...

False Positives for iam_role_cross_service_confused_deputy_prevention AWS ec2.amazonaws.com

so @D592 you would execute the check only for specific service roles and not apply it to all the services?

add default policy document to create_vpc_endpoint

Hi @bblommers, thank you for your quick response! I was able to force the creation of the default policy that AWS provides if no PolicyDocument is given: ``` PolicyDocument=json.dumps( {...

feat(ec2): improve EC2 Security Groups checks logic by checking if any instance is attached

Please @jfagoagas, review if the logic and functions used for the first check is correct in order to do the same for the rest of the checks.

Implement a new check for secrets in CloudWatch Logs

For sure @Fennerr , great idea! I could help you with the metadata 💪🏼

Make iam_policy_no_administrative_privileges check configurable to scan AWS managed policies

Hi @addefisher, thank you for reaching us out! Good idea, we will adjust to CIS regarding the attachment of the policies and make a configurable option for the scope.

Make iam_policy_no_administrative_privileges check configurable to scan AWS managed policies

Sorry for the delay, I just created the PR with the changes. As CISv1.5 control 1.16 requires to check attaches policies for both custom or AWS managed, it did not...