yourfolio icon indicating copy to clipboard operation
yourfolio copied to clipboard

The header image changes size and position after compressing browser window.

Open lj-valencia opened this issue 3 years ago • 2 comments

Hello,

Thank you for creating this great theme! I may have encountered an issue and I am wondering if this is a bug. I noticed that whenever I compress the browser window, the position and size of the header image change when I revert back to the maximum browser size. I thought this was only a problem when I ran the theme via localhost:1313, but I tried doing this on the demo page via the Hugo themes page and the same results happened. I attached some snapshots below from the demo page (hugo themes).

Here's a snapshot of the demo page when window size is maximized: yourfolio-original

Here's a snapshot of the demo page when the browser window is compressed: yourfolio-small-window

Here is a snapshot of the demo page, browser window size is maximized after compressing the browser window (header image noticeably smaller): yourfolio-changed

The header image reverts back to its original form when I reload the page. I'm wondering if anyone else using the theme encountered this. I suppose addressing this issue would involve changing img in the critical.scss file but I'm not sure if i'm on the right track with my thinking or how I'd proceed with addressing this issue.

Thanks again for creating this webpage!

lj-valencia avatar May 26 '21 05:05 lj-valencia

Hello @lj-valencia, Thank you for your interest to this theme and thank you for your kind words!

At current moment, I am not sure why this happens. Needs further investigation.

For now you could apply quick fix by replacing max-width: 100%; with width: 100%; in line 93 here.

Hope this helps! Have a great day!

serg avatar May 26 '21 07:05 serg

Hello @serg,

Thank you for replying, the quick fix worked!

Best, LJ

lj-valencia avatar Jun 07 '21 05:06 lj-valencia