serenity icon indicating copy to clipboard operation
serenity copied to clipboard

updating some dependencies

Open DRuppFv opened this issue 3 years ago • 6 comments
trafficstars

There are more dependencies not updated, as bitflags, serde_json, chrono and probably some others, but i just updated the really outdated or that had performance updates ones

DRuppFv avatar Jul 07 '22 23:07 DRuppFv

The only actual update here is simd-json, the others are semver compatible so will automatically be updated when selected for Cargo.lock

GnomedDev avatar Jul 07 '22 23:07 GnomedDev

The only actual update here is simd-json, the others are semver compatible so will automatically be updated when selected for Cargo.lock

Oh. I didn't know that. It had performance updates, then the PR is still valid, i think?

DRuppFv avatar Jul 07 '22 23:07 DRuppFv

The tracing and reqwest updates are not helpful because it forces needless dependency updates on people who are still running older (but semver-compatible) dependency versions

kangalio avatar Jul 10 '22 15:07 kangalio

Actually, isn't this a breaking change? We publically expose simd_json types, for example in the serenity::json module

I believe the PR should be retargetted at next

kangalio avatar Jul 14 '22 08:07 kangalio

This should be bumped to 0.6, now that is out.

GnomedDev avatar Aug 07 '22 10:08 GnomedDev

I think we can close this PR, there hasn't been activity on bumping the simd-json to the new latest version so the PR is outdated

kangalio avatar Sep 20 '22 23:09 kangalio