poise icon indicating copy to clipboard operation
poise copied to clipboard

Published 20 hours ago • verified publisher icon serenity-rs

.unwrap_or_default() instead of falling back to "<prefix>" in single-command help

Open SIGSTACKFAULT opened this issue 10 months ago • 2 comments

fixes #254

SIGSTACKFAULT avatar Mar 26 '24 02:03 SIGSTACKFAULT

Hi, thanks for the fix! Reading the code comments in the removed code, I would prefer you make the fallback string configurable, bc for dynamic prefixes, an empty string is not a good fallback either

kangalio avatar Mar 26 '24 18:03 kangalio

@kangalio help_all_commands already falls back to not showing any prefix here so i copied that logic.

I think this whole file would need a bit of a rewrite

SIGSTACKFAULT avatar Mar 26 '24 19:03 SIGSTACKFAULT