poise icon indicating copy to clipboard operation
poise copied to clipboard

Published 20 hours ago • verified publisher icon serenity-rs

Re-enable `simdjson` test in `ci.yml`

Open scottbot95 opened this issue 1 year ago • 2 comments

The simdjson test was disabled in 1b0f83bcb0ddea24bf82ddfa3b84f3918be50ebb due to upstream issues with the serenity/simdjson (serenity-rs/serenity#2474). Once upstream issues are resolved, we should re-enable the simdjson test.

scottbot95 avatar Jul 16 '23 18:07 scottbot95

We have removed simd-json in serenity-rs/serenity#2735 on the next branch. Is this still valid (current still has it but is there any purpose to getting it to work if it still doesn't)?

jamesbt365 avatar May 25 '24 12:05 jamesbt365

I don't think we need to re-enable this test anymore if we've removed simd-json entirely. Probably should cleanup the workflow though and any other references to simd-json https://github.com/serenity-rs/poise/blob/6c26be9d3fa6ee092b9e418618596dfdf443097b/.github/workflows/ci.yml#L47

scottbot95 avatar Jun 30 '24 02:06 scottbot95