serde icon indicating copy to clipboard operation
serde copied to clipboard

Add #[serde(rename_all_fields = "foo")] attribute

Open jplatte opened this issue 5 years ago • 9 comments

fixes #1061

If you don't like the style change in the second commit, I can remove it from this PR (or you can just cherry-pick the first commit).

jplatte avatar Dec 15 '19 18:12 jplatte

r? @dtolnay

jplatte avatar Dec 20 '19 18:12 jplatte

I'll try again since Triagebot Notifications are now a thing:

r? @dtolnay

I've opened this PR because you wrote over at https://github.com/serde-rs/serde/issues/1061#issuecomment-451716365 that you'd accept a PR for this. If your opinion has changed, I won't be upset if this is closed without further reasoning.

jplatte avatar Mar 28 '20 13:03 jplatte

@dtolnay it looks like this was approved a few months back but not merged in.

kjeremy avatar Jul 20 '20 19:07 kjeremy

@kjeremy The person who left the review doesn't seem to be associated with serde in any way.

jplatte avatar Jul 20 '20 22:07 jplatte

Rebased to trigger new CI runs, the old ones had been stuck for months.

jplatte avatar Oct 02 '20 17:10 jplatte

CI fixed, no merge conflics. Ping @dtolnay

jplatte avatar Oct 23 '20 23:10 jplatte

Are there no plans on merging this in? This really would be a feature I'd love to have.

roberts-pumpurs avatar Feb 17 '21 07:02 roberts-pumpurs

+1 on this merge...

kaiba42 avatar Aug 05 '21 06:08 kaiba42

Would love this!

llgerard avatar Apr 12 '22 17:04 llgerard

Any update on this? Would love to have this merged as well.

pmhpereira avatar Jan 15 '23 11:01 pmhpereira

Rebased to fix conflicts with the syn 2.0 upgrade.

jplatte avatar Jul 10 '23 09:07 jplatte