Shawn P. Serbin comments

Results 106 comments of


                                            Shawn P. Serbin

Rework CLM test suite: miscellaneous things to do to shorten turnaround time and increase coverage

All I would strongly second this! When working with the NGEE-Tropics version of FATES I was running the test suite after each new PR (e.g. clm_45_short, clm_5_short, fates tests), I...

Too many open files issue again?

More errors like this. This time with a DALEC run: ``` 2016-04-02 12:19:04 INFO [read.output] : Reading output for Years: 2000 - 2002 in directory: /data/Model_Output/pecan.output/PEcAn_2000000138/out/2000010646 including files 2000.nc 2001.nc...

Too many open files issue again?

Here is the run setup: pecan.xml ``` test run DALEC ponderosa pine 2000000002 Shawn P. Serbin 2016/04/02 11:44:53 -0400 /data/Model_Output/pecan.output/PEcAn_2000000138 bety bety localhost bety PostgreSQL TRUE dalec.pondersoa_pine 1 /data/Model_Output/pecan.output/PEcAn_2000000138/pft/dalec.pondersoa_pine dalec.pondersoa_pine...

Too many open files issue again?

Need to check the get.model.output code to make sure files are being closed properly

Too many open files issue again?

@ashiklom @bcow I think we can start by confirming that the recent changes to PEcAn have not accidentally caused this issue by removing or modify the calls to close netCDF...

Too many open files issue again?

Actually after looking back over I bet the issue is in the read model output step.

Too many open files issue again?

It may be in read.ensemble.output() If you don't locate I will take another look in a little bit. It may not be in the read output / convert to standardized...

Possible bug: PEcAn output sometime repeats first/last date/time between years or starts at -1

Here is an example of raw SIPNET output ``` Notes: (PlantWoodC, PlantLeafC, Soil and Litter in g C/m^2; Water and Snow in cm; SoilWetness is fraction of WHC; loc year...

Possible bug: PEcAn output sometime repeats first/last date/time between years or starts at -1

WRT SIPNET the issue is here ``` t vals = sub.sipnet.output$day - 1 + (sub.sipnet.output$time/24) > head(vals) [1] -1.0000000 -0.9583333 -0.9166667 -0.8750000 -0.8333333 -0.7916667 ``` versus ``` > vals =...

Possible bug: PEcAn output sometime repeats first/last date/time between years or starts at -1

With ED2 its a bit tricky because in python (ILAMB): ``` from netCDF4 import num2date,date2num print num2date(365.,"days since 2001-01-01 00:00:00") print num2date( 0.,"days since 2002-01-01 00:00:00") ``` gives ``` 2002-01-01...