Mobile-Detect icon indicating copy to clipboard operation
Mobile-Detect copied to clipboard

Published 20 hours ago • verified publisher icon serbanghita

PHP 8 Support

Open adlenton opened this issue 3 years ago • 5 comments

Hey,

I took the liberty to propose a minimal changeset for php 8 support and with that also drop support for unsupported php versions (https://www.php.net/supported-versions.php).

  • dropped support for php versions older than 7.2
  • updated phpunit version
  • compatibility fixes

adlenton avatar Oct 23 '20 09:10 adlenton

@serbanghita I'm also waiting for this PR, as it's blocking us from a full PHP8 upgrade :)

brainexe avatar Dec 16 '20 13:12 brainexe

@adlenton Thank you, I actually needed this! I'm review-ing it and this will be the basis of 3.0.0

serbanghita avatar Jan 26 '21 09:01 serbanghita

@bogdananton can you look into this PR as well?

serbanghita avatar Jan 26 '21 09:01 serbanghita

@brainexe I will move as fast as I can. There is also this PR that I have to account for https://github.com/serbanghita/Mobile-Detect/pull/823 Can you also review the current PR changes?

serbanghita avatar Jan 26 '21 10:01 serbanghita

Is there any update on this?

We have tons of those

PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/runner/work/.../vendor/mobiledetect/mobiledetectlib/Mobile_Detect.php on line 1460

in our CI system now for PHP 8.1+ etc.

dereuromark avatar Nov 01 '21 22:11 dereuromark

I have opened a PR for support of PHP7 https://github.com/serbanghita/Mobile-Detect/pull/900

This PR contains shallow changes and I cannot continue with it in this state. If any of you guys want to be a reviewer on https://github.com/serbanghita/Mobile-Detect/pull/900 - let me know

serbanghita avatar Nov 09 '22 17:11 serbanghita