Mobile-Detect icon indicating copy to clipboard operation
Mobile-Detect copied to clipboard

Making use of php-cs-fixer applying the PSR-2 standard

Open mynameisbogdan opened this issue 5 years ago • 5 comments

Making use of php-cs-fixer applying the PSR-2 standard.

mynameisbogdan avatar Oct 10 '19 02:10 mynameisbogdan

- friendsofphp/php-cs-fixer v2.15.3 requires php ^5.6 || ^7.0 -> your PHP version (5.3.29) does not satisfy that requirement.

Can we make the dev build work for 5.3, 5.4 and 5.5? See https://travis-ci.org/serbanghita/Mobile-Detect/builds/595904568

serbanghita avatar Oct 11 '19 05:10 serbanghita

Sadly friendsofphp/php-cs-fixer has been php 5.6 and up for a while and the only solution is to remove it from require-dev and install it globally if you want to use it.

Would you also like to include examples and tests?

I'm thinking of adding friendsofphp/php-cs-fixer to suggest and running it in travis only php 5.6 and up. What do you think?

mynameisbogdan avatar Oct 11 '19 08:10 mynameisbogdan

@mynameisbogdan I agree

serbanghita avatar Oct 13 '19 11:10 serbanghita

@serbanghita done. :)

mynameisbogdan avatar Oct 13 '19 12:10 mynameisbogdan

Why not just use StyleCI?

It's free for open source 👍

JayBizzle avatar Jan 09 '20 21:01 JayBizzle