crates icon indicating copy to clipboard operation
crates copied to clipboard

Enabled and fixed features autocompletion

Open trevarj opened this issue 2 years ago • 1 comments

  • Uncommented the completion provider for crate features. This was working for single line dependencies (under [dependencies], but not when a dependency is a toml table.
  • On toml parsing, within filterCrates, store a dependency item's extra values (other than just the version). Doing this allows us to get the feature field later.

*Some ESLint fixes were automatically applied.

trevarj avatar Oct 31 '21 17:10 trevarj

npm test isn't working for me. Is there a way to run the tests?

trevarj avatar Oct 31 '21 17:10 trevarj

this feature would make working with features so much easier. It's a pain to always have to open the docs or clone the repo and look at the Cargo.toml. Please merge this, I tested it and it seems to be working just fine.

unknowntrojan avatar Oct 28 '23 10:10 unknowntrojan

@unknowntrojan I rebased with the latest master so that this can be merged, if wanted by @serayuzgur. Would you mind testing it again? I kind of forgot about this and I don't use VSCode anymore.

trevarj avatar Oct 28 '23 12:10 trevarj

It does not seem to be working as before

unknowntrojan avatar Oct 28 '23 16:10 unknowntrojan

I see, thanks for looking. I think I will just close this then, since there hasn't been a response from the repo owner anyway - no sense in me installing VSCode and starting to debug for nothing.

trevarj avatar Oct 28 '23 16:10 trevarj

Hi, If you fix it , I can release in next version. Thanks

On Sat, Oct 28, 2023 at 19:38 Trevor Arjeski @.***> wrote:

I see, thanks for looking. I think I will just close this then, since there hasn't been a response from the repo owner anyway - no sense in me installing VSCode and starting to debug for nothing.

— Reply to this email directly, view it on GitHub https://github.com/serayuzgur/crates/pull/150#issuecomment-1783865901, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCZTMU3NLFNV5BE3XEMOGDYBUYIJAVCNFSM5HCQJGB2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZYGM4DMNJZGAYQ . You are receiving this because you were mentioned.Message ID: @.***>

serayuzgur avatar Oct 28 '23 16:10 serayuzgur