crates icon indicating copy to clipboard operation
crates copied to clipboard

Show error when an invalid feature is added

Open saiintbrisson opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe. Sometimes a typo is committed when declaring a feature, and I don't get feedback until I try compiling the project.

Describe the solution you'd like It would be helpful to add an error on the feature declaration line, or perhaps below the feature itself.

saiintbrisson avatar Mar 26 '21 22:03 saiintbrisson

After giving it a look, I figured that it might not be possible, and therefore I will close this issue

saiintbrisson avatar Mar 26 '21 22:03 saiintbrisson

@SaiintBrisson This is actually possible, you can reopen this

WilliamVenner avatar Apr 10 '21 02:04 WilliamVenner

Well, it's possible, but after a review of the parsing code it would take a lot of work and a huge refactor. Might not be worth it.

WilliamVenner avatar Apr 10 '21 16:04 WilliamVenner

Yeah, that's what I thought too, I'll leave this open for now, the maintainers may close this if they want to.

saiintbrisson avatar Apr 11 '21 01:04 saiintbrisson

@saiintbrisson if you describe how to check it, I can take a look at the parser and see how much time it will take.

serayuzgur avatar Jan 03 '22 09:01 serayuzgur

This would be a great enhancement. I think it'd also work well with crate feature listing and/or feature autocomplete. Does this already exist in the Crates extension?

lvkv avatar Sep 24 '23 21:09 lvkv