AWScala icon indicating copy to clipboard operation
AWScala copied to clipboard

Published 20 hours ago • verified publisher icon seratch

Merge in Kinesis implementation?

Open colindean opened this issue 7 years ago • 3 comments

https://github.com/bizreach/aws-kinesis-scala provides "jp.co.bizreach" %% "aws-kinesis-scala" and seems to have a very similar implementation style.

Maybe it could be or serve as the basis of implementing Kinesis support?

colindean avatar May 10 '18 18:05 colindean

It may be fine. What do you think? @takezoe

seratch avatar May 15 '18 00:05 seratch

aws-kinesis-scala consists the core module and the spark support module. I think the core module can be merged with AWScala basically, but it contains not only Scala wrapper of AWS-SDK but some additional features like automatic retry fashion. I'm not sure these features should be merged.

takezoe avatar May 15 '18 05:05 takezoe

Thank you for your detailed explanation. I prefer a simple wrapper of Java SDK.

Anyway, if somebody makes a pull request to merge a Kinesis module, I am willing to merge it regardless of whether it's based on aws-kinesis-scala or not.

seratch avatar May 18 '18 12:05 seratch