website icon indicating copy to clipboard operation
website copied to clipboard

V7-alpha connectionManager.initPools missing

Open ghost opened this issue 1 year ago • 1 comments

Issue Creation Checklist

  • [x] I understand that my issue will be automatically closed if I don't fill in the requested information
  • [x] I have read the contribution guidelines

Bug Description

Using V7-alpha the connectionManager no longer has a initPools method to restart the connection pool when using it in an AWS Lambda environment.

Is the way to do this changed in V7? I tried looking through the source but could not find a way to do this with the same behaviour as on V6

Reproducible Example

Here is the link to the SSCCE for this issue:

What do you expect to happen?

What is actually happening?

Environment

  • Sequelize version: 7.0.0-alpha.32
  • Node.js version: v18.16.0
  • If TypeScript related: TypeScript version:
  • Database & Version: PostgreSQL
  • Connector library & Version:

Would you be willing to resolve this issue by submitting a Pull Request?

  • [ ] Yes, I have the time and I know how to start.
  • [ ] Yes, I have the time but I will need guidance.
  • [ ] No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • [x] No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in resolving my issue.

Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.

ghost avatar Sep 26 '23 08:09 ghost

That code has moved to the constructor in sequelize/sequelize#14652. As maintainers we don't have AWS Lambda experience as far as I know so this one is up to the community. Once this is cleared up, feel free to open a PR to update the page

WikiRik avatar Sep 26 '23 08:09 WikiRik