website icon indicating copy to clipboard operation
website copied to clipboard

Incorrect documentation on "Using Sequelize in AWS Lambda"

Open fathergoose opened this issue 3 years ago • 2 comments

Hello sequelize maintainers, this is my first time contributing here. Forgive me if anything about this issue is off.

On Using Sequelize in AWS Lambda there are instructions for how one should manage a connection when in an AWS Lambda environment. On line 73 of the source there is a call sequelize.connectionManager.initPools().

From what I can tell, initPools was moved/removed with the release of 7.0.0-alpha15 when connectionManager was converted to typescript by @ephys.

I'm not sure if there is a new way to perform the function of initPools as described in the Lambda document, or if the feature was never supposed to be exposed in the first place. It doesn't seem to be part of the public API from what I can tell, at least not anymore.

I'm happy to make a PR to update the docs, or expose a new initPools method, but I don't know enough about the maintainers' intent or enough about the role of the previous initPools as used in the docs.

fathergoose avatar Aug 10 '22 04:08 fathergoose

It seems to be part of the constructor now. Therefore it's not a part of the public API anymore, but I'm not so sure what to do in this case. I'll assign @ephys to this so she can look into this later.

WikiRik avatar Aug 13 '22 11:08 WikiRik

Hi y'all. My team is still stuck with alpha 13 without additional guidance because of the problem outlined above. I don't need much from the sequelize crew, I'm just looking to be pointed in the right direction.

I am happy to make a PR to either sequelize/sequelize and-or sequelize/website with a little bit of guidance. However, as of now, I'm not sure the function initPools was serving or the intention behind the refactor which removed it (is there documentation update to be made, or perhaps code to be added to serve in place of the former initPools method, or both?)

Admittedly, issues opened against the website repo may not be the best way of communicating with the sequelize team. I noticed a slack link on the website. I can meet there too for a more dynamic/real-time conversation.

Thanks!

fathergoose avatar Sep 07 '22 18:09 fathergoose