sequelize icon indicating copy to clipboard operation
sequelize copied to clipboard

feat: replace correlated subquery with EXISTS

Open dazhuangc opened this issue 1 year ago • 3 comments
trafficstars

Pull Request Checklist

  • [x] Have you added new tests to prevent regressions?
  • [x] If a documentation update is necessary, have you opened a PR to the documentation repository?
  • [x] Did you update the typescript typings accordingly (if applicable)?
  • [x] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [x] Does the name of your PR follow our conventions?

Description of Changes

https://github.com/sequelize/sequelize/issues/17344

List of Breaking Changes

N/A

dazhuangc avatar Jun 03 '24 07:06 dazhuangc

db2 latest (Node 18) failed with address already in use, but db2 oldest (Node 18) and db2 oldest/latest (Node 20) succeeded. https://github.com/sequelize/sequelize/actions/runs/9364519084/job/25778026149 I think the failure is caused by the CI process, not the code change. Could someone trigger a rerun? I seem to lack permission.

dazhuangc avatar Jun 04 '24 09:06 dazhuangc

I think the CI process is kinda flaky, someone already reruns it :)

fzn0x avatar Jun 04 '24 10:06 fzn0x

@fzn0x Thanks for your comment! Could you review this PR or guide me on what I should do next?

dazhuangc avatar Jun 07 '24 08:06 dazhuangc

Hi, Could someone review and merge this PR? Or I have to skip 40 integration tests for HANA dialect, which lead to execution failure on HANA.

dazhuangc avatar Jan 21 '25 02:01 dazhuangc