sequelize
sequelize copied to clipboard
meta: add ibmi smoke tests to CI
Pull Request Checklist
- [ ] Have you added new tests to prevent regressions?
- [ ] If a documentation update is necessary, have you opened a PR to the documentation repository?
- [ ] Did you update the typescript typings accordingly (if applicable)?
- [ ] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
- [ ] Does the name of your PR follow our conventions?
Description Of Change
Rework of #14432 Closes #14432
Future PRs should see if we could split install-and-build from here and have a template action in both CI and this workflow.
Todos
- [x] Do we want to run this on both Node 14 and Node 18?
- [ ] Do we need to rework the smoke test file as well before merging this?
Do we want to run this on both Node 14 and Node 18?
Probably not considering how incredibly slow it is
This PR is on hold for now until we hear from Mark about the IBMI_CONN_STR value since we cannot retrieve it from GitHub itself and without it I can't do testing without committing which adds too much overhead to development
Are smoke tests something we still want to do?
Imo yes, I actually signed up for an account at pub400 recently and will be trying that out soon
I found a message back from Mark earlier (can't find it now, so not linking it). He mentioned a server from Germany already where it took 8 minutes to run a single test. This is most likely the same server as pub400 so I'm closing this. If we want to revisit this later; I do have the credentials for a working account