sequelize icon indicating copy to clipboard operation
sequelize copied to clipboard

feat: Add CockroachDb support

Open divye11 opened this issue 2 years ago • 1 comments

Pull Request Checklist

  • [x] Have you added new tests to prevent regressions?
  • [ ] If a documentation update is necessary, have you opened a PR to the documentation repository?
  • [x] Did you update the typescript typings accordingly (if applicable)?
  • [ ] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [x] Does the name of your PR follow our conventions?

Description Of Change

  • Added dialect support, data types, query generator in order to support cockroachdb natively from sequelize.

Todos

  • [ ] CockroachDB transaction isolation works differently, need to find a better way to run tests involving transactions.

divye11 avatar Jan 17 '23 12:01 divye11

I do actually like the changes in reducing the whitespaces. Is there a linter that you use for this? Would be nice to add this to our eslint config in a separate PR to improve this

WikiRik avatar Apr 25 '23 13:04 WikiRik