sequelize-typescript icon indicating copy to clipboard operation
sequelize-typescript copied to clipboard

feat: added declare to docs

Open NGorco opened this issue 1 year ago • 3 comments

Adding proper model fields definitions that doesn't conflict with vanilla Sequelize. Addressing that problem https://sequelize.org/docs/v6/core-concepts/model-basics/#caveat-with-public-class-fields

NGorco avatar May 02 '23 15:05 NGorco

I was just reading the updated sequelize docs and was thinking to add the pr to this and found this. I think you should put a blurb in the docs linking to the official docs about public fields so that users can understand the need for the change and the model reference. This would be a great pr to merge.

blankstar85 avatar Sep 26 '23 14:09 blankstar85

@blankstar85 Thanks, will do.

NGorco avatar Oct 12 '23 16:10 NGorco

@blankstar85 Added more info

NGorco avatar Nov 08 '23 17:11 NGorco