cli icon indicating copy to clipboard operation
cli copied to clipboard

Support Unix sockets in --url

Open jo-so opened this issue 7 years ago • 6 comments

I would like to access my database via Unix socket. This requires to use a path as hostname, but not all path characters are valid for a hostname. Rust's r2d2 database driver uses an URL-encoded form of the hostname like: postgres://joerg@%2Frun%2Fpostgresql:5433/codimd?application_name=CodiMD. Maybe you could support this, too. Or use a query parameter for this.

jo-so avatar Oct 12 '18 07:10 jo-so

Sequelize itself supports a socket given as a host parameter like:

postgres://postgres@/unstoppable_website_development?host=/tmp

But not sequelize-cli

Its weird that sequelize-cli doesn't reuse that code from sequelize itself.

bogdan avatar Jul 04 '19 14:07 bogdan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 21 '20 19:06 stale[bot]

I think it's up to the devs to implement this request. This issue stalled, because the devs didn't react.

jo-so avatar Jun 21 '20 20:06 jo-so

Tagging this as feature request

I think it's up to the devs to implement this request. This issue stalled, because the devs didn't react.

@jo-so I don't have infinite time at my hand. I will appreciate a PR with proper test

sushantdhiman avatar Jun 22 '20 04:06 sushantdhiman

Does the feature tag keep away the stale bot?

jo-so avatar Jun 29 '20 08:06 jo-so

Yes, but issues will be disabled soon and only PRs will be accepted, so it wont matter if issue is closed or open

sushantdhiman avatar Jun 30 '20 05:06 sushantdhiman