nf-tower icon indicating copy to clipboard operation
nf-tower copied to clipboard

Workflow topics feature

Open pditommaso opened this issue 5 years ago • 5 comments

The workflow page should display include a tagging feature in the top bar just on the right of the workflow name.

It should work along the same way of GitHub project tags i.e. allow the users to add and remove text free tags. The system should suggest existing tags while typing.

It requires the creation of a new entity

class WorkflowTag {
    String text 
    OffsetDateTime dateCreated
    static belongsTo = [workflow: Workflow]
}

pditommaso avatar Jul 16 '19 10:07 pditommaso

Two quick questions:

  • Text length limit?
  • Any invalid characters or specific format to follow?

tcrespog avatar Aug 27 '19 10:08 tcrespog

Let's follow github

Topics must start with a lowercase letter or number, consist of 35 characters or less, and can include hyphens.

pditommaso avatar Aug 27 '19 10:08 pditommaso

Done in branch workflow_tags.

tcrespog avatar Aug 28 '19 05:08 tcrespog

I've rebased the workflow_tags branch with the latest changes on master. Therefore update your copy before doing/pushing other changes.

Some comments about the current version:

  • Let's remove any Tag successfully created/deleted feedback message
  • When clicking the + tag the label should only be created in the view (no record should be created), the new tag edit should get the focus. The tag is persisted only when the user press enter
  • When editing the tag and pressing enter the tag should be saved (currently a new-line is added like in a multiline control)
  • Rename everything from tag to topic

pditommaso avatar Aug 28 '19 15:08 pditommaso

This is great! A couple of add-on requests for us (maybe better in a separate issue?)

  • Key-value pairs would be better for us
    • Example would be project, input_concentration etc.
    • We can get around this by prefixing tags etc, but pairs would be better
  • Ability to submit with the job, preferably through nextflow
    • This could be through a new nextflow config scope?
    • Avoiding nextflow and doing this when launching nextflow via tower would be an acceptable alternative

The reason for both of these is that we have a tonne of metadata in our LIMS. If we're using tower for automating this, then we want to add the metadata in automatically so that we can link everything up.

Single-word tags added by hand are nice, but I'm not sure that they scale so well for large numbers of runs.

ewels avatar Feb 19 '20 09:02 ewels