nf-tower icon indicating copy to clipboard operation
nf-tower copied to clipboard

Workflow comment tab

Open pditommaso opened this issue 5 years ago • 6 comments

The workflow page contains a note tab that should allow the use to annotate workflow in blog comment style approach.

Therefore when clicked the tab should show a list of comments (date, text) and a text field add a new comment.

It requires the creation of a new entity:

class WorkflowComment {
   String text 
   OffsetDateTime dateCreated
   static belongsTo = [workflow: Workflow]
}

pditommaso avatar Jul 16 '19 10:07 pditommaso

Ideally this feature should be added as a new tab in the top panel Screenshot 2019-11-21 at 17 15 56

pditommaso avatar Nov 21 '19 16:11 pditommaso

It can be inspired to the GitHub comments feature. However, for now, it should be kept easy. Only plain text, no images or formatting. It should be reported. It would be nice to report the user name, icon and datetime of the comment somehow similarly to GitHub comments

pditommaso avatar Nov 21 '19 16:11 pditommaso

Screenshot-from-2019-12-03-11-34-03

pditommaso avatar Dec 03 '19 09:12 pditommaso

@clvadym I've merged the PR in the branch dev-workflow-notes. The small problem to fix is that when the comments are visualised and the user selects a different workflow (clicks on the left sidebar) the comments are not updated accordingly.

pditommaso avatar Dec 05 '19 08:12 pditommaso

Also, endpoint errors should be reported as shown below:

https://github.com/seqeralabs/nf-tower/blob/63aca5fda0b2de0035b7e82482bec9e584f72379/tower-web/src/app/modules/main/component/access-token/access-token.component.ts#L100-L102

pditommaso avatar Dec 05 '19 08:12 pditommaso